Add the guidelines github workflow from app-boilerplate #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elric1
force-pushed
the
elric1@upstream-guidelines
branch
9 times, most recently
from
4c3e1bb to
31b14ad
Compare
|
overall LGTM, but might want to see if we can wait until swap is merged, and then resurrect LedgerHQ/ledger-app-database#69 |
elric1
force-pushed
the
elric1@upstream-guidelines
branch
from
31b14ad to
e67730d
Compare
elric1
force-pushed
the
elric1@upstream-guidelines
branch
3 times, most recently
from
2f3d0c9 to
3d0fcff
Compare
elric1
force-pushed
the
elric1@upstream-guidelines
branch
from
3d0fcff to
6b8d141
Compare
elric1
force-pushed
the
elric1@upstream-guidelines
branch
from
6b8d141 to
630ec48
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
elric1
force-pushed
the
elric1@upstream-guidelines
branch
2 times, most recently
from
e0fde81 to
4e5b15f
Compare
elric1
force-pushed
the
elric1@upstream-guidelines
branch
from
4e5b15f to
2ed1c20
Compare
spalmer25
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only had to make minor modifications to get this working. This first to note is that in their
guidelines_enforcer.yml, we needed to specify that we build things from a subdirectory. After finding that config option, things are much easier.They run
clang --analyze, so we had to change a few remainingstrcpy(3)'s intostrlcpy(3).And, we had to alter the app variant name to
tezos_walletand update the app flags to match what Ledger stores upstream in a DB that they maintain to doublecheck that you aren't changing this without filing a PR against said DB. We preserve the existing flags as specified in that DB, but we believe that the flags should be reviewed as: